fix: DH-22099: stop loading when input filter change has no effect on…#2643
Merged
mofojed merged 1 commit intodeephaven:release/v0.85from Mar 25, 2026
Merged
Conversation
… grid filters (deephaven#2639) - When Ctrl+E clears all filters, the grid's `clearAllFilters()` removes quick filters and stops loading. However, the input filter's debounced clear arrives later, triggering `startLoading('Filtering...')` in `componentDidUpdate`. Since the filters were already cleared, `applyInputFilters()` finds no changes, never calls `setState`, and the model update/stopLoading never fires - leaving the grid stuck. - Fix: make `applyInputFilters()` return whether filters actually changed. If no change occurred, immediately call `stopLoading()` to cancel the loading state that was optimistically started. - Add e2e test for Ctrl+E clear filters with input filter stuck in Filtering state - Manually tested in Core to verify fix
mofojed
changed the title
vbabich
approved these changes
Mar 25, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/v0.85 #2643 +/- ##
=================================================
- Coverage 48.57% 48.57% -0.01%
=================================================
Files 712 712
Lines 39793 39795 +2
Branches 9938 10130 +192
=================================================
Hits 19331 19331
+ Misses 20449 20407 -42
- Partials 13 57 +44
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… grid filters (#2639)
clearAllFilters()removes quick filters and stops loading. However, the input filter's debounced clear arrives later, triggeringstartLoading('Filtering...')incomponentDidUpdate. Since the filters were already cleared,applyInputFilters()finds no changes, never callssetState, and the model update/stopLoading never fires - leaving the grid stuck.applyInputFilters()return whether filters actually changed. If no change occurred, immediately callstopLoading()to cancel the loading state that was optimistically started.