Skip to content

fix: peerDependencies in iris-grid should just use react >=16 #2658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mofojed wants to merge 1 commit into from
Closed

fix: peerDependencies in iris-grid should just use react >=16 #2658

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions packages/iris-grid/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,8 +62,8 @@
"react-transition-group": "^4.4.2"
},
"peerDependencies": {
"react": ">=18.0.0",
"react-dom": ">=18.0.0"
"react": ">=16.8.0",
"react-dom": ">=16.8.0"
Comment on lines +65 to +66
Copy link

Copilot AI Apr 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The package is built with Babel preset-react using runtime: 'automatic', which emits imports from react/jsx-runtime. That entrypoint is only available starting in React 16.14 (and 17+). Setting the peer dependency to >=16.8.0 would allow React 16.8–16.13, which will fail at runtime due to missing react/jsx-runtime. Consider bumping the minimum to >=16.14.0 (and matching react-dom) or switching the build output to the classic JSX runtime if true 16.8 support is required.

Suggested change
"react": ">=16.8.0",
"react-dom": ">=16.8.0"
"react": ">=16.14.0",
"react-dom": ">=16.14.0"

Copilot uses AI. Check for mistakes.
},
"devDependencies": {
"@deephaven/jsapi-shim": "file:../jsapi-shim",
Expand Down
Loading
⚡