Skip to content

DH-22326: Un-hide group-by columns, keep other hidden columns hidden when applying rollup#2667

Closed
vbabich wants to merge 2 commits intomainfrom
vlad-DH-22326
Closed

DH-22326: Un-hide group-by columns, keep other hidden columns hidden when applying rollup#2667
vbabich wants to merge 2 commits intomainfrom
vlad-DH-22326

Conversation

@vbabich
Copy link
Copy Markdown
Collaborator

@vbabich vbabich commented May 4, 2026

Fix DH-22326: when applying a rollup, group-by columns now become visible while previously-hidden non-grouped columns stay hidden across the model swap. Replaces the previous showAllColumns() reset in handleRollupChange with a targeted metricCalculator.resetColumnWidth call for each group-by column, so the metric calculator's existing by-name width tracking handles preservation automatically. Also eliminates the brief flicker that the previous reset caused.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 4, 2026

Pull Request titles must follow the Conventional Commits specification.

Details:

No release type found in pull request title "DH-22326: Un-hide group-by columns, keep other hidden columns hidden when applying rollup". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

@vbabich vbabich closed this May 4, 2026
@vbabich vbabich deleted the vlad-DH-22326 branch May 4, 2026 19:13
@github-actions github-actions Bot locked and limited conversation to collaborators May 4, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant