Update tooling with dellctl install powerstore#1698
Conversation
content/docs/tooling/cli/_index.md
Outdated
| > | reclaimPolicy | Delete | | ||
| > | volumeBindingMode | Immediate | | ||
| > | csi-volume-prefx | csivol | | ||
| > | csi-node-prefix | csi-node | |
content/docs/tooling/cli/_index.md
Outdated
| @@ -83,6 +83,130 @@ Outputs help text | |||
|
|
|||
| --- | |||
|
|
|||
| ### dellctl install powerstore | |||
|
|
|||
| Installs Dell CSI Powerstore | |||
There was a problem hiding this comment.
This command deploys the CSI PowerStore driver and optional modules in your Kubernetes or OpenShift environment.
content/docs/tooling/cli/_index.md
Outdated
|
|
||
| Installs Dell CSI Powerstore | ||
|
|
||
| ##### Flags |
content/docs/tooling/cli/_index.md
Outdated
|
|
||
| ```bash | ||
| --certified Optional. If set, the certified sample files pulling from registry.redhat.com are displayed instead of quay.io sample files. | ||
| --config-version string Optional version of Container Storage Modules to install. Defaults to the latest version. |
content/docs/tooling/cli/_index.md
Outdated
| --certified Optional. If set, the certified sample files pulling from registry.redhat.com are displayed instead of quay.io sample files. | ||
| --config-version string Optional version of Container Storage Modules to install. Defaults to the latest version. | ||
| --csi-node-prefix string Optional param to set the prefix for all CSI nodes provisioned by the driver. Defaults to 'csi-node'. | ||
| --csi-volume-prefix string Optional param to set the prefix for all CSI volumes provisioned by the driver. Defaults to 'csivol'. |
There was a problem hiding this comment.
No description provided.
content/docs/tooling/cli/_index.md
Outdated
| --config-version string Optional version of Container Storage Modules to install. Defaults to the latest version. | ||
| --csi-node-prefix string Optional param to set the prefix for all CSI nodes provisioned by the driver. Defaults to 'csi-node'. | ||
| --csi-volume-prefix string Optional param to set the prefix for all CSI volumes provisioned by the driver. Defaults to 'csivol'. | ||
| --csm-authorization-proxy-hostname string Optional. If deploying CSM Authorization, this parameter will be used for the Authorization Proxy hostname in the Operator configuration. |
There was a problem hiding this comment.
Updated for . Can you clarify what you mean by "No description provided."?
content/docs/tooling/cli/_index.md
Outdated
| -s, --storage stringArray Storage endpoint configuration in the form 'endpoint=<IP|hostname>,username=<user>[,otherKey=otherValue]'. Can be provided multiple times. | ||
| --tenant-token string Path to a YAML file containing Authorization tenant token (proxy-authz-token secret). | ||
| --validate-connectivity Optional. If set, run a DaemonSet on all nodes and verify connectivity to storage systems. | ||
| ``` |
There was a problem hiding this comment.
Updated. Also moved these flags to the dellctl install command as they will be redundant for each platform.
content/docs/tooling/cli/_index.md
Outdated
|
|
||
| ```bash | ||
| --certified Optional. If set, the certified sample files pulling from registry.redhat.com are displayed instead of quay.io sample files. | ||
| --config-version string Optional version of Container Storage Modules to install. Defaults to the latest version. |
content/docs/tooling/cli/_index.md
Outdated
| @@ -11,6 +11,8 @@ This document outlines all dellctl commands, their intended use, options that ca | |||
| | Command | Description | | |||
| | - | - | | |||
| | [dellctl](../cli/#dellctl) | dellctl is used to interact with Container Storage Modules | | |||
| | [dellctl install](../cli/#dellctl-install) | Install a Dell CSI Driver | | |||
content/docs/tooling/cli/_index.md
Outdated
| @@ -11,6 +11,8 @@ This document outlines all dellctl commands, their intended use, options that ca | |||
| | Command | Description | | |||
| | - | - | | |||
| | [dellctl](../cli/#dellctl) | dellctl is used to interact with Container Storage Modules | | |||
| | [dellctl install](../cli/#dellctl-install) | Install a Dell CSI Driver | | |||
| | [dellctl install powerstore](../cli/#dellctl-install-powerstore) | Install Dell CSI Powerstore | | |||
There was a problem hiding this comment.
dellctl install powerstore is specific for Powerstore. I think this command should say Powerstore specifically.
Install CSI Powerstore?
There was a problem hiding this comment.
This is the description, just remove the Dell. Install Dell CSI Powerstore > Install CSI Powerstore
dont change the command.
content/docs/tooling/cli/_index.md
Outdated
| dellctl install powerstore --from-file=config.yaml | ||
| ``` | ||
|
|
||
| Sample config.yaml to install pre-requisities and validate connectivity: |
There was a problem hiding this comment.
Suggestion: Could we have a drop down here; one for a minimal config and the other showing all the options in the config?
|
During installation flow, how we are guiding customer to use the alternate method with dellctl installation? |
Updating the installation flow pages will be another PR. |
ecb7de7 to
6664022
Compare
content/docs/tooling/cli/_index.md
Outdated
| ##### Examples: | ||
|
|
||
| ```bash | ||
| dellctl install powerstore --machineconfig --validate-connectivity \ |
content/docs/tooling/cli/_index.md
Outdated
|
|
||
| This command deploys the CSI PowerStore driver and optional modules in your Kubernetes or OpenShift environment. | ||
|
|
||
| ##### Examples: |
There was a problem hiding this comment.
question: should we add a small piece about which flags are only allowed to be used through --from-file? Just looking through the sample config.yaml might result in some users not knowing about the existence of some options.
There was a problem hiding this comment.
Added this section to dellctl install.
| reclaimPolicy: Delete | ||
| volumeBindingMode: WaitForFirstConsumer | ||
| allowVolumeExpansion: true | ||
| allowedTopologies: |
There was a problem hiding this comment.
question: is this legal formatting for the topologies? I have been using something like
allowedTopologies:
- key: csi-powerstore.dellemc.com/<IP>
values:
- true
There was a problem hiding this comment.
Formatting it correctly for the storge class is handled in generation/creation.
content/docs/tooling/cli/_index.md
Outdated
|
|
||
| >**NOTE:** `--machineconfig` is applicable for both OpenShift and Kubernetes. | ||
| > | ||
| > **DEFAULTS**: |
There was a problem hiding this comment.
Should we add all defaults here?
| Setting | Value |
|---|---|
| nfs-acls | 0777 |
| skip-certificate-validation | false |
| config-version | latest version of CSM |
There are also more default values in the storage class configurations, but it might be too much here if we only want CLI/from-file specific defaults here.
content/docs/tooling/cli/_index.md
Outdated
| | csm-authorization-proxy-hostname <string> | If deploying CSM Authorization, the hostname of the Authorization Proxy Server. | No | | ||
| | force | The existing Container Storage Module resources are deleted and then recreated. | No | | ||
| | from-file <string> | Path to a YAML file containing configuration details for installing the CSM. | No | | ||
| | machineconfig | Configure pre-requisities based on the provided block-protocol parameter. | No | |
There was a problem hiding this comment.
Might be nice to mention what prerequisites are being installed here. There isn't much clarity on what this flag is doing. I think part of the reason is it's used for both K8s and OCP, but for now, maybe link one of the prerequisites pages:
There was a problem hiding this comment.
Updated the description with a link to the installation page for the user to navigate to the relevant orchestrator and platform.
We only support Powerstore right now but that will change and I thought it was ok.
| ```bash | ||
| dellctl install powerstore --from-file=config.yaml | ||
| ``` | ||
|
|
There was a problem hiding this comment.
Config file examples
There was a problem hiding this comment.
The examples are in the dropdowns just below this.
content/docs/tooling/cli/_index.md
Outdated
| dellctl install powerstore --from-file=config.yaml | ||
| ``` | ||
|
|
||
| {{< collapse id="1" title="Sample config.yaml to install pre-requisities and validate connectivity" card="false" >}} |
There was a problem hiding this comment.
Check prerequisites and connectivity
There was a problem hiding this comment.
It doesn't check, it installs. There is a separate option to check connectivity.
content/docs/tooling/cli/_index.md
Outdated
| ``` | ||
| {{< /collapse >}} | ||
|
|
||
| {{< collapse id="2" title="Sample config.yaml to to output yaml" card="false" >}} |
There was a problem hiding this comment.
Specify output format to yaml.
content/docs/tooling/cli/_index.md
Outdated
| ``` | ||
| {{< /collapse >}} | ||
|
|
||
| {{< collapse id="3" title="Sample config.yaml with all configuration options" card="false" >}} |
content/docs/tooling/cli/_index.md
Outdated
|
|
||
| ##### Output | ||
|
|
||
| Outputs help text |
There was a problem hiding this comment.
This phrase is used elsewhere for other commands so I followed that pattern. For dellctl install, it will only output help text which isn't shown here as it's long.
content/docs/tooling/cli/_index.md
Outdated
|
|
||
| > **NOTE:** `--machineconfig` is applicable for both OpenShift and Kubernetes. | ||
| > | ||
| > **DEFAULTS**: |
There was a problem hiding this comment.
Can this added to existing table? and have one more column as default value?
content/docs/tooling/cli/_index.md
Outdated
| > - skip-certificate-validation | ||
| > - storage-class | ||
| > - metro-replication | ||
| > - primary |
There was a problem hiding this comment.
primary? - some explanation about it? no examples on primary or secondary.
5e0ec53 to
5f54093
Compare


Description
GitHub Issues
List the GitHub issues impacted by this PR:
Checklist: