Refactor admin_debug_packages tests to match structured output format#342
Open
prasant750h wants to merge 1 commit intodell:automation-v2.1.0.0from
Open
Refactor admin_debug_packages tests to match structured output format#342prasant750h wants to merge 1 commit intodell:automation-v2.1.0.0from
prasant750h wants to merge 1 commit intodell:automation-v2.1.0.0from
Conversation
- Modified test_admin_debug_packages.py to use structured details format - Changed output from multiple log.check() calls to single details string - Updated functional group display from '═══ group ═══' to '[group]' format - Enhanced node display with proper indentation showing IP and status - All three test cases now follow consistent format matching test_pam_slurm_adopt - Fixed pylint issues: trailing whitespace, f-string without interpolation - Added pylint disable for import-error and too-many-locals - Code now passes pylint with 10.00/10 rating Test output improvements: - test_admin_debug_packages_config: Shows config existence and presence - test_admin_debug_packages_json: Lists all packages with proper formatting - test_debug_packages_installed: Groups nodes by functional group with detailed status
abhishek-sa1
reviewed
Apr 2, 2026
| } | ||
|
|
||
| # ============================================================================= | ||
| def get_packages_from_json(host) -> List[str]: |
Contributor
There was a problem hiding this comment.
can you create a dynamic function to verify in aarch64 cluster also
| # Path to admin_debug_packages.json inside omnia_core container | ||
| ADMIN_DEBUG_PACKAGES_JSON = ( | ||
| "/opt/omnia/input/project_default/config" | ||
| "/x86_64/rhel/10.0/admin_debug_packages.json" |
Contributor
There was a problem hiding this comment.
add for aarch64 as well
| ) | ||
|
|
||
| # ============================================================================= | ||
| def test_admin_debug_packages_config(host): |
Contributor
There was a problem hiding this comment.
This is not actually a test case. You can check this as a part of function [it can be a helper function as well]. also core module have that functionality, please check and utilize it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test output improvements: