feat(python): combine load_version/load_with_datetime into load_as_version

[ion-elgreco]

Description

Combines the two functions into one.

Related Issue(s)

• closes Rethink the load_version and load_with_datetime interfaces #1910
• closes .load_with_datetime() is incorrectly rounding to nearest second #1967

[roeap]

thanks for this refactor.

somehow I am not a fan of the name load_to, but also don't have a better one ready.

[roeap]

maybe an opportunity to fix #1967 as well?

[ion-elgreco]

thanks for this refactor.

somehow I am not a fan of the name load_to, but also don't have a better one ready.

@roeap maybe we can just name it load or load_state instead?

[roeap]

I try to always see if it works as a short sentence ... "load [table] to version" just somehow hit my ear wrong 😆.

Would "load [table] as version" work? load alone may be confusion as well, as this may be misconsrued as the table still needs to be loaded?

[ion-elgreco]

@roeap Yeah when you read it like that it doesn't sound right haha. Hmm, that would translate into load_as_version or load_asof?

[roeap]

Not sure myself, but what would you think about at ...

table.at(version)

[ion-elgreco]

@roeap I think at is to unclear. Would the previously mentioned load_state not be more clear? Since it's doing that?

[ion-elgreco]

maybe an opportunity to fix #1967 as well?

@roeap fixing this, causes now one of the restore test in Rusts to fail, not sure what to do here because all python tests pass fine. Maybe the timing of the rust written table is to close to each other?

[roeap]

👍