Skip to content

feat: add custom dynamodb endpoint configuration#2575

Merged
ion-elgreco merged 20 commits intodelta-io:mainfrom
hnaoto:add_dynamodb_endpoint_configuration
Jun 7, 2024
Merged

feat: add custom dynamodb endpoint configuration#2575
ion-elgreco merged 20 commits intodelta-io:mainfrom
hnaoto:add_dynamodb_endpoint_configuration

Conversation

@hnaoto
Copy link
Copy Markdown
Contributor

@hnaoto hnaoto commented Jun 6, 2024

Description

Add custom dynamodb endpoint configuration
Users can specify dynamodb endpoint in the map or set the environment variable AWS_ENDPOINT_URL_DYNAMODB to override dynamodb client endpoint.

Related Issue(s)

2498

Documentation

@hnaoto hnaoto requested review from roeap, rtyler and wjones127 as code owners June 6, 2024 04:36
@github-actions github-actions bot added the binding/rust Issues for the Rust crate label Jun 6, 2024
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jun 6, 2024

ACTION NEEDED

delta-rs follows the Conventional Commits specification for release automation.

The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification.

@hnaoto hnaoto changed the title feat: Add custom dynamodb endpoint configuration feat: add custom dynamodb endpoint configuration Jun 6, 2024
@ion-elgreco
Copy link
Copy Markdown
Collaborator

@hnaoto thanks!

@ion-elgreco ion-elgreco merged commit 0a44a0d into delta-io:main Jun 7, 2024
@ion-elgreco
Copy link
Copy Markdown
Collaborator

@hnaoto can you also update the docs on s3 and dynamodb later on with this new change?

@hnaoto
Copy link
Copy Markdown
Contributor Author

hnaoto commented Jun 8, 2024

Thanks for reviewing the PR @ion-elgreco !

Yes, would you mind me asking where I can find the docs? Is it this one https://delta-io.github.io/delta-rs/usage/writing/writing-to-s3-with-locking-provider/ (for python)? The rust one is automatically generated. Is there another user guide for Rust?

@ion-elgreco
Copy link
Copy Markdown
Collaborator

@hnaoto that's the one yeah, you should see the related markdown file somewhere in the repo.

There is no specific guide for Rust, but this one is written generic enough. It's just that the example is often in Python

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

binding/rust Issues for the Rust crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants