chore: more manual inline format args#3251
Merged
ion-elgreco merged 2 commits intodelta-io:mainfrom Feb 25, 2025
Merged
Conversation
298bc3e to
13facb8
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3251 +/- ##
==========================================
+ Coverage 72.05% 72.09% +0.04%
==========================================
Files 143 143
Lines 45586 45530 -56
Branches 45586 45530 -56
==========================================
- Hits 32845 32824 -21
+ Misses 10665 10622 -43
- Partials 2076 2084 +8 ☔ View full report in Codecov by Sentry. |
Manually fixed format argument inlining to improve readability, and fix a few minor related styling issues like trailing commas in a single line. Signed-off-by: Yuri Astrakhan <YuriAstrakhan@gmail.com>
Signed-off-by: Yuri Astrakhan <YuriAstrakhan@gmail.com>
3dbf3d3 to
eef9b34
Compare
ion-elgreco
approved these changes
Feb 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manually fixed format argument inlining to improve readability, and fix a few minor related styling issues like trailing commas in a single line.
Note that in many places I have removed the
&because it is rarely needed in a format arg, but makes code run ~5% slower (compiler cannot yet eliminate that)