Skip to content

perf(snapshot): minor memory allocation and usage reduction without cloning #3903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rtyler merged 2 commits into from
Oct 28, 2025
Merged

perf(snapshot): minor memory allocation and usage reduction without cloning #3903

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1a93653
perf(snapshot): use std::mem:take to reduce memory allocation and com…
fvaleye Oct 28, 2025
3bff800
perf(snapshot): use std::mem:take to reduce memory allocation and com…
fvaleye Oct 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,4 +116,3 @@ inherits = "release"
opt-level = 3
codegen-units = 1
lto = "fat"
strip = true
2 changes: 1 addition & 1 deletion crates/core/src/kernel/snapshot/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,8 @@
use object_store::path::Path;
use object_store::ObjectStore;
use serde_json::Deserializer;
use tokio::task::spawn_blocking;

Check warning on line 42 in crates/core/src/kernel/snapshot/mod.rs

View workflow job for this annotation

GitHub Actions / cloud (gcp) 

unused import: `tokio::task::spawn_blocking`

Check warning on line 42 in crates/core/src/kernel/snapshot/mod.rs

View workflow job for this annotation

GitHub Actions / check 

unused import: `tokio::task::spawn_blocking`

Check warning on line 42 in crates/core/src/kernel/snapshot/mod.rs

View workflow job for this annotation

GitHub Actions / Integration Tests (LakeFS v1.48) 

unused import: `tokio::task::spawn_blocking`

Check warning on line 42 in crates/core/src/kernel/snapshot/mod.rs

View workflow job for this annotation

GitHub Actions / build (ubuntu-latest) 

unused import: `tokio::task::spawn_blocking`

Check warning on line 42 in crates/core/src/kernel/snapshot/mod.rs

View workflow job for this annotation

GitHub Actions / build (ubuntu-latest) 

unused import: `tokio::task::spawn_blocking`

Check warning on line 42 in crates/core/src/kernel/snapshot/mod.rs

View workflow job for this annotation

GitHub Actions / build (ubuntu-latest) 

unused import: `tokio::task::spawn_blocking`

Check warning on line 42 in crates/core/src/kernel/snapshot/mod.rs

View workflow job for this annotation

GitHub Actions / build (ubuntu-latest) 

unused import: `tokio::task::spawn_blocking`

Check warning on line 42 in crates/core/src/kernel/snapshot/mod.rs

View workflow job for this annotation

GitHub Actions / aws-native-tls 

unused import: `tokio::task::spawn_blocking`

Check warning on line 42 in crates/core/src/kernel/snapshot/mod.rs

View workflow job for this annotation

GitHub Actions / cloud (azure) 

unused import: `tokio::task::spawn_blocking`

Check warning on line 42 in crates/core/src/kernel/snapshot/mod.rs

View workflow job for this annotation

GitHub Actions / Integration Tests (HDFS) 

unused import: `tokio::task::spawn_blocking`

Check warning on line 42 in crates/core/src/kernel/snapshot/mod.rs

View workflow job for this annotation

GitHub Actions / cloud (aws) 

unused import: `tokio::task::spawn_blocking`

Check warning on line 42 in crates/core/src/kernel/snapshot/mod.rs

View workflow job for this annotation

GitHub Actions / Unit Tests (ubuntu-latest) 

unused import: `tokio::task::spawn_blocking`

Check warning on line 42 in crates/core/src/kernel/snapshot/mod.rs

View workflow job for this annotation

GitHub Actions / test-minimal 

unused import: `tokio::task::spawn_blocking`

Check warning on line 42 in crates/core/src/kernel/snapshot/mod.rs

View workflow job for this annotation

GitHub Actions / Running with Python 3.10 

unused import: `tokio::task::spawn_blocking`

Check warning on line 42 in crates/core/src/kernel/snapshot/mod.rs

View workflow job for this annotation

GitHub Actions / Running with Python 3.11 

unused import: `tokio::task::spawn_blocking`

Check warning on line 42 in crates/core/src/kernel/snapshot/mod.rs

View workflow job for this annotation

GitHub Actions / Python Build (Python 3.10 LakeFS Integration tests) 

unused import: `tokio::task::spawn_blocking`

Check warning on line 42 in crates/core/src/kernel/snapshot/mod.rs

View workflow job for this annotation

GitHub Actions / Running with Python 3.12 

unused import: `tokio::task::spawn_blocking`

Check warning on line 42 in crates/core/src/kernel/snapshot/mod.rs

View workflow job for this annotation

GitHub Actions / Running with Python 3.9 

unused import: `tokio::task::spawn_blocking`

Check warning on line 42 in crates/core/src/kernel/snapshot/mod.rs

View workflow job for this annotation

GitHub Actions / Python Build (Python 3.10 Unity Catalog Integration tests) 

unused import: `tokio::task::spawn_blocking`

Check warning on line 42 in crates/core/src/kernel/snapshot/mod.rs

View workflow job for this annotation

GitHub Actions / Python Build (Python 3.10 PyArrow latest) 

unused import: `tokio::task::spawn_blocking`

Check warning on line 42 in crates/core/src/kernel/snapshot/mod.rs

View workflow job for this annotation

GitHub Actions / Python Build (Python 3.10 Unity Catalog Integration tests) 

unused import: `tokio::task::spawn_blocking`

Check warning on line 42 in crates/core/src/kernel/snapshot/mod.rs

View workflow job for this annotation

GitHub Actions / PySpark Integration Tests 

unused import: `tokio::task::spawn_blocking`
use tracing::Instrument;

Check warning on line 43 in crates/core/src/kernel/snapshot/mod.rs

View workflow job for this annotation

GitHub Actions / cloud (gcp) 

unused import: `tracing::Instrument`

Check warning on line 43 in crates/core/src/kernel/snapshot/mod.rs

View workflow job for this annotation

GitHub Actions / check 

unused import: `tracing::Instrument`

Check warning on line 43 in crates/core/src/kernel/snapshot/mod.rs

View workflow job for this annotation

GitHub Actions / Integration Tests (LakeFS v1.48) 

unused import: `tracing::Instrument`

Check warning on line 43 in crates/core/src/kernel/snapshot/mod.rs

View workflow job for this annotation

GitHub Actions / build (ubuntu-latest) 

unused import: `tracing::Instrument`

Check warning on line 43 in crates/core/src/kernel/snapshot/mod.rs

View workflow job for this annotation

GitHub Actions / build (ubuntu-latest) 

unused import: `tracing::Instrument`

Check warning on line 43 in crates/core/src/kernel/snapshot/mod.rs

View workflow job for this annotation

GitHub Actions / build (ubuntu-latest) 

unused import: `tracing::Instrument`

Check warning on line 43 in crates/core/src/kernel/snapshot/mod.rs

View workflow job for this annotation

GitHub Actions / build (ubuntu-latest) 

unused import: `tracing::Instrument`

Check warning on line 43 in crates/core/src/kernel/snapshot/mod.rs

View workflow job for this annotation

GitHub Actions / aws-native-tls 

unused import: `tracing::Instrument`

Check warning on line 43 in crates/core/src/kernel/snapshot/mod.rs

View workflow job for this annotation

GitHub Actions / cloud (azure) 

unused import: `tracing::Instrument`

Check warning on line 43 in crates/core/src/kernel/snapshot/mod.rs

View workflow job for this annotation

GitHub Actions / Integration Tests (HDFS) 

unused import: `tracing::Instrument`

Check warning on line 43 in crates/core/src/kernel/snapshot/mod.rs

View workflow job for this annotation

GitHub Actions / cloud (aws) 

unused import: `tracing::Instrument`

Check warning on line 43 in crates/core/src/kernel/snapshot/mod.rs

View workflow job for this annotation

GitHub Actions / Unit Tests (ubuntu-latest) 

unused import: `tracing::Instrument`

Check warning on line 43 in crates/core/src/kernel/snapshot/mod.rs

View workflow job for this annotation

GitHub Actions / test-minimal 

unused import: `tracing::Instrument`

Check warning on line 43 in crates/core/src/kernel/snapshot/mod.rs

View workflow job for this annotation

GitHub Actions / Running with Python 3.10 

unused import: `tracing::Instrument`

Check warning on line 43 in crates/core/src/kernel/snapshot/mod.rs

View workflow job for this annotation

GitHub Actions / Running with Python 3.11 

unused import: `tracing::Instrument`

Check warning on line 43 in crates/core/src/kernel/snapshot/mod.rs

View workflow job for this annotation

GitHub Actions / Python Build (Python 3.10 LakeFS Integration tests) 

unused import: `tracing::Instrument`

Check warning on line 43 in crates/core/src/kernel/snapshot/mod.rs

View workflow job for this annotation

GitHub Actions / Running with Python 3.12 

unused import: `tracing::Instrument`

Check warning on line 43 in crates/core/src/kernel/snapshot/mod.rs

View workflow job for this annotation

GitHub Actions / Running with Python 3.9 

unused import: `tracing::Instrument`

Check warning on line 43 in crates/core/src/kernel/snapshot/mod.rs

View workflow job for this annotation

GitHub Actions / Python Build (Python 3.10 Unity Catalog Integration tests) 

unused import: `tracing::Instrument`

Check warning on line 43 in crates/core/src/kernel/snapshot/mod.rs

View workflow job for this annotation

GitHub Actions / Python Build (Python 3.10 PyArrow latest) 

unused import: `tracing::Instrument`

Check warning on line 43 in crates/core/src/kernel/snapshot/mod.rs

View workflow job for this annotation

GitHub Actions / Python Build (Python 3.10 Unity Catalog Integration tests) 

unused import: `tracing::Instrument`

Check warning on line 43 in crates/core/src/kernel/snapshot/mod.rs

View workflow job for this annotation

GitHub Actions / PySpark Integration Tests 

unused import: `tracing::Instrument`
use url::Url;

use super::{Action, CommitInfo, Metadata, Protocol};
Expand Down Expand Up @@ -544,7 +544,7 @@
log_store,
None,
current_version,
Box::new(self.files.clone().into_iter()),
Box::new(std::mem::take(&mut self.files).into_iter()),
None,
)
.try_collect()
Expand Down
Loading
⚡