fix: correctly rectify Urls with dots in DeltaTableBuilder#3929
Merged
rtyler merged 2 commits intodelta-io:mainfrom Nov 12, 2025
Merged
fix: correctly rectify Urls with dots in DeltaTableBuilder#3929rtyler merged 2 commits intodelta-io:mainfrom
rtyler merged 2 commits intodelta-io:mainfrom
Conversation
…om_uri Signed-off-by: R. Tyler Croy <rtyler@brokenco.de>
Signed-off-by: R. Tyler Croy <rtyler@brokenco.de>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3929 +/- ##
==========================================
+ Coverage 73.94% 73.98% +0.03%
==========================================
Files 153 153
Lines 39477 39489 +12
Branches 39477 39489 +12
==========================================
+ Hits 29193 29214 +21
+ Misses 8960 8953 -7
+ Partials 1324 1322 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
hntd187
approved these changes
Nov 12, 2025
Collaborator
hntd187
left a comment
There was a problem hiding this comment.
One question, but otherwise GTG
| let fields = self | ||
| .iter() | ||
| .map(|(k, v)| { | ||
| let sep = String::from('/'); |
Collaborator
There was a problem hiding this comment.
Would this clone the string on every interspersion? Pedantic here, but maybe a const SEP: &str = "/"; would make more sense?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While doing some unrelated work I did some dry-by test coverage addition and discovered this issue with some of our DAT tests.
The only way I believe we can be certain our path segments don't have
..in them is to re-parse theUrl😢