fix: add missing field to snapshot serde#3984
Merged
roeap merged 2 commits intodelta-io:mainfrom Dec 14, 2025
Merged
Conversation
roeap
force-pushed
the
fix/kerne-serde
branch
from
d7d3be4 to
4839019
Compare
roeap
changed the title
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3984 +/- ##
===========================================
+ Coverage 26.52% 74.50% +47.97%
===========================================
Files 124 152 +28
Lines 19991 39966 +19975
Branches 19991 39966 +19975
===========================================
+ Hits 5302 29775 +24473
+ Misses 14327 8854 -5473
- Partials 362 1337 +975 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Robert Pack <robstar.pack@gmail.com>
Signed-off-by: Robert Pack <robstar.pack@gmail.com>
roeap
force-pushed
the
fix/kerne-serde
branch
from
3585710 to
296e6be
Compare
ethan-tyler
pushed a commit
to ethan-tyler/delta-rs
that referenced
this pull request
Jan 9, 2026
# Description We were omitting a field form (de)serializing a field on lig segment when implemeneting serde for our snapshots. Signed-off-by: Robert Pack <robstar.pack@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We were omitting a field form (de)serializing a field on log segment when implementing serde for our snapshots.