Skip to content

chore: normalize Url going into logstore and update everything to take references#3985

Merged
rtyler merged 1 commit intodelta-io:mainfrom
rtyler:chore/more-normalizing
Dec 16, 2025
Merged

chore: normalize Url going into logstore and update everything to take references#3985
rtyler merged 1 commit intodelta-io:mainfrom
rtyler:chore/more-normalizing

Conversation

@rtyler
Copy link
Copy Markdown
Member

@rtyler rtyler commented Dec 14, 2025

This is a follow up to #3962 where some leftover comments were not
addressed

Signed-off-by: R. Tyler Croy rtyler@brokenco.de

@github-actions github-actions bot added the binding/rust Issues for the Rust crate label Dec 14, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Dec 14, 2025

Codecov Report

❌ Patch coverage is 88.23529% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.25%. Comparing base (d2812f0) to head (9212338).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/core/src/logstore/mod.rs 90.90% 1 Missing and 1 partial ⚠️
crates/aws/src/logstore/default_logstore.rs 0.00% 1 Missing ⚠️
crates/core/src/operations/convert_to_delta.rs 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #3985       +/-   ##
===========================================
+ Coverage   26.35%   74.25%   +47.89%     
===========================================
  Files         124      152       +28     
  Lines       20109    40072    +19963     
  Branches    20109    40072    +19963     
===========================================
+ Hits         5300    29755    +24455     
+ Misses      14447     8982     -5465     
- Partials      362     1335      +973     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…e references

This is a follow up to delta-io#3962 where some leftover comments were not
addressed

Signed-off-by: R. Tyler Croy <rtyler@brokenco.de>
@rtyler rtyler force-pushed the chore/more-normalizing branch from c4c4b70 to 9212338 Compare December 15, 2025 23:55
@rtyler rtyler marked this pull request as ready for review December 16, 2025 14:06
@rtyler rtyler enabled auto-merge (rebase) December 16, 2025 14:06
@rtyler rtyler merged commit 65dabb9 into delta-io:main Dec 16, 2025
29 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

binding/rust Issues for the Rust crate

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants