fix: make session the first argument of update_datafusion_session#4192
Merged
ion-elgreco merged 2 commits intodelta-io:mainfrom Feb 11, 2026
Merged
Conversation
44c8d93 to
dd888e5
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #4192 +/- ##
==========================================
- Coverage 76.65% 76.64% -0.02%
==========================================
Files 166 166
Lines 47016 46994 -22
Branches 47016 46994 -22
==========================================
- Hits 36040 36017 -23
- Misses 9195 9197 +2
+ Partials 1781 1780 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
added 2 commits
February 11, 2026 09:01
Signed-off-by: Paul Douane <paul.douane@icloud.com>
Signed-off-by: Paul Douane <paul.douane@icloud.com>
0a3e53a to
7ead39a
Compare
Contributor
Author
|
Hi, this is my first contribution to delta-rs I noticed that Codecov shows some partial coverage on Please let me know if I should add additional tests or if this is okay as-is. Thanks! |
ion-elgreco
approved these changes
Feb 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
update_datafusion_sessioncurrently updates the state of the Session while receiving it as the second argument.This change reorders the function parameters so that the Session is passed as the first argument, matching the intent discussed in the issue.
Related Issue(s)
Documentation