Skip to content

fix: make session the first argument of update_datafusion_session#4192

Merged
ion-elgreco merged 2 commits intodelta-io:mainfrom
pauldouane:fix/update-datafusion-session-args
Feb 11, 2026
Merged

fix: make session the first argument of update_datafusion_session#4192
ion-elgreco merged 2 commits intodelta-io:mainfrom
pauldouane:fix/update-datafusion-session-args

Conversation

@pauldouane
Copy link
Copy Markdown
Contributor

Description

update_datafusion_session currently updates the state of the Session while receiving it as the second argument.

This change reorders the function parameters so that the Session is passed as the first argument, matching the intent discussed in the issue.

Related Issue(s)

Documentation

@github-actions github-actions Bot added the binding/rust Issues for the Rust crate label Feb 10, 2026
@pauldouane pauldouane force-pushed the fix/update-datafusion-session-args branch from 44c8d93 to dd888e5 Compare February 10, 2026 20:13
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 11, 2026

Codecov Report

❌ Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.64%. Comparing base (34516c8) to head (7ead39a).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/core/src/operations/delete.rs 0.00% 0 Missing and 1 partial ⚠️
crates/core/src/operations/update.rs 0.00% 0 Missing and 1 partial ⚠️
crates/core/src/operations/write/mod.rs 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4192      +/-   ##
==========================================
- Coverage   76.65%   76.64%   -0.02%     
==========================================
  Files         166      166              
  Lines       47016    46994      -22     
  Branches    47016    46994      -22     
==========================================
- Hits        36040    36017      -23     
- Misses       9195     9197       +2     
+ Partials     1781     1780       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Paul Douane added 2 commits February 11, 2026 09:01
Signed-off-by: Paul Douane <paul.douane@icloud.com>
Signed-off-by: Paul Douane <paul.douane@icloud.com>
@pauldouane pauldouane force-pushed the fix/update-datafusion-session-args branch from 0a3e53a to 7ead39a Compare February 11, 2026 08:03
@pauldouane
Copy link
Copy Markdown
Contributor Author

Hi, this is my first contribution to delta-rs

I noticed that Codecov shows some partial coverage on update_datafusion_session and ensure_log_store_registered, but I only changed the order of arguments in update_datafusion_session. I’m not sure if this coverage issue is blocking for this PR.

Please let me know if I should add additional tests or if this is okay as-is. Thanks!

@ion-elgreco ion-elgreco merged commit 47ef3b5 into delta-io:main Feb 11, 2026
25 of 26 checks passed
@pauldouane pauldouane deleted the fix/update-datafusion-session-args branch February 11, 2026 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

binding/rust Issues for the Rust crate

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

update_datafusion_session has the wrong order of arguments

2 participants