fix: coerce decimal literals in target subset filters#4267
Merged
ion-elgreco merged 1 commit intodelta-io:mainfrom Mar 10, 2026
Merged
fix: coerce decimal literals in target subset filters#4267ion-elgreco merged 1 commit intodelta-io:mainfrom
ion-elgreco merged 1 commit intodelta-io:mainfrom
Conversation
Signed-off-by: Ethan Urbanski <ethan@urbanskitech.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4267 +/- ##
==========================================
- Coverage 76.85% 76.85% -0.01%
==========================================
Files 167 167
Lines 49098 49139 +41
Branches 49098 49139 +41
==========================================
+ Hits 37735 37766 +31
- Misses 9453 9459 +6
- Partials 1910 1914 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ion-elgreco
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Found this while working on #4266.
Merge target subset filters can retain decimal precision/scale from the source expression instead of the target schema. For example
decimal(4, 1)when the column isdecimal(6, 1). The newer file skipping path rejects the mismatch.This fix is normalize
target_subset_filteragainst the target schema before simplification, and extend literal coercion to handle between bounds.Related Issue(s)
Documentation