Skip to content

refactor: centralize default Parquet writer properties#4335

Merged
ethan-tyler merged 5 commits intodelta-io:mainfrom
ethan-tyler:refactor/default-writer-properties-created-by
Apr 7, 2026
Merged

refactor: centralize default Parquet writer properties#4335
ethan-tyler merged 5 commits intodelta-io:mainfrom
ethan-tyler:refactor/default-writer-properties-created-by

Conversation

@ethan-tyler
Copy link
Copy Markdown
Collaborator

follow up from #4326

Default WriterProperties construction was duplicated across write paths and had drifted where optimize set created_by and other paths didn't.

Adds a shared helper for default Parquet writer properties and wires it through write, JSON, record-batch, checkpoint, and optimize paths. Sets created_by = "delta-rs version <version>" consistently. Existing compression defaults preserved (SNAPPY for standard writes/checkpoints, ZSTD(4) for optimize).

One place to maintain defaults and less drift risk.

Signed-off-by: Ethan Urbanski <ethan@urbanskitech.com>
@github-actions github-actions Bot added the binding/rust Issues for the Rust crate label Apr 5, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 5, 2026

Codecov Report

❌ Patch coverage is 98.64865% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.62%. Comparing base (df786bf) to head (e1905a0).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/core/src/delta_datafusion/mod.rs 95.34% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4335      +/-   ##
==========================================
+ Coverage   77.52%   77.62%   +0.10%     
==========================================
  Files         169      170       +1     
  Lines       51995    52106     +111     
  Branches    51995    52106     +111     
==========================================
+ Hits        40309    40448     +139     
+ Misses       9560     9527      -33     
- Partials     2126     2131       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

ion-elgreco
ion-elgreco previously approved these changes Apr 5, 2026
Signed-off-by: Ethan Urbanski <ethan@urbanskitech.com>
Signed-off-by: Ethan Urbanski <ethan@urbanskitech.com>
@ethan-tyler ethan-tyler force-pushed the refactor/default-writer-properties-created-by branch from 5a873fe to eecfcd7 Compare April 5, 2026 20:25
@ethan-tyler ethan-tyler marked this pull request as ready for review April 5, 2026 20:40
@ethan-tyler ethan-tyler enabled auto-merge (squash) April 5, 2026 20:41
@ethan-tyler ethan-tyler requested a review from ion-elgreco April 5, 2026 20:42
@ethan-tyler ethan-tyler merged commit c8f9184 into delta-io:main Apr 7, 2026
26 of 27 checks passed
@rtyler rtyler added this to the delta-rs 0.32.0 milestone Apr 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

binding/rust Issues for the Rust crate

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants