refactor: centralize default Parquet writer properties#4335
Merged
ethan-tyler merged 5 commits intodelta-io:mainfrom Apr 7, 2026
Merged
Conversation
Signed-off-by: Ethan Urbanski <ethan@urbanskitech.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4335 +/- ##
==========================================
+ Coverage 77.52% 77.62% +0.10%
==========================================
Files 169 170 +1
Lines 51995 52106 +111
Branches 51995 52106 +111
==========================================
+ Hits 40309 40448 +139
+ Misses 9560 9527 -33
- Partials 2126 2131 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ion-elgreco
previously approved these changes
Apr 5, 2026
Signed-off-by: Ethan Urbanski <ethan@urbanskitech.com>
Signed-off-by: Ethan Urbanski <ethan@urbanskitech.com>
5a873fe to
eecfcd7
Compare
ion-elgreco
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
follow up from #4326
Default
WriterPropertiesconstruction was duplicated across write paths and had drifted where optimize setcreated_byand other paths didn't.Adds a shared helper for default Parquet writer properties and wires it through write, JSON, record-batch, checkpoint, and optimize paths. Sets
created_by = "delta-rs version <version>"consistently. Existing compression defaults preserved (SNAPPY for standard writes/checkpoints, ZSTD(4) for optimize).One place to maintain defaults and less drift risk.