fix(lockfile): gracefully skip empty package names in package.json dependencies#33094
Open
wdskuki wants to merge 1 commit intodenoland:mainfrom
Open
fix(lockfile): gracefully skip empty package names in package.json dependencies#33094wdskuki wants to merge 1 commit intodenoland:mainfrom
wdskuki wants to merge 1 commit intodenoland:mainfrom
Conversation
…pendencies
This fixes an issue where lockfile deserialization fails when package.json
contains empty package names (e.g., {"": "."}), which can occur from
recursive npm installs.
Instead of failing the entire deserialization, invalid entries are now
silently skipped, allowing the lockfile to load successfully.
Fixes denoland#32113
|
|
bartlomieju
reviewed
Apr 1, 2026
Comment on lines
+31
to
+34
| // Should not fail to deserialize - empty package names are skipped | ||
| // Note: This is a compile-time deserialization test | ||
| // The actual runtime behavior depends on JsrDepPackageReq parsing | ||
| let _content = lockfile_content; // Placeholder - actual test requires async setup |
Member
There was a problem hiding this comment.
Looks like AI slop with unfinished test
bartlomieju
requested changes
Apr 1, 2026
Member
bartlomieju
left a comment
bartlomieju
left a comment
There was a problem hiding this comment.
Did you use AI to create this PR?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an issue where lockfile deserialization fails when package.json contains empty package names (e.g.,
{"": "."}), which can occur from recursive npm installs.Instead of failing the entire deserialization, invalid entries are now silently skipped, allowing the lockfile to load successfully.
Fixes: #32113
Testing:
Changes:
deserialize_package_json_depsthat skips invalid entries