fix(ext/node): add limits property on node:sqlite DatabaseSync#33106
Open
Tango992 wants to merge 10 commits intodenoland:mainfrom
Open
fix(ext/node): add limits property on node:sqlite DatabaseSync#33106Tango992 wants to merge 10 commits intodenoland:mainfrom
limits property on node:sqlite DatabaseSync#33106Tango992 wants to merge 10 commits intodenoland:mainfrom
Conversation
Tango992
force-pushed
the
node-sqlite-limit
branch
from
72b45ca to
949de23
Compare
Tango992
commented
Apr 1, 2026
Contributor
Author
There was a problem hiding this comment.
This proxy was created for this test case to pass: https://github.com/nodejs/node/blob/2ea7a7b67c3d698a0e80d2591365e2dc5c5f7a81/test/parallel/test-sqlite-limits.js#L158-L172
Tango992
force-pushed
the
node-sqlite-limit
branch
from
faf7c20 to
0ba72df
Compare
Tango992
force-pushed
the
node-sqlite-limit
branch
2 times, most recently
from
b9f8d60 to
0ae6a64
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows https://github.com/nodejs/node/blob/v25.8.1/test/parallel/test-sqlite-limits.js test to pass. Most implementation logics were written by Claude