Skip to content

add annotation to container spec and add validation to it #661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yangcao77 merged 3 commits into from
Nov 2, 2021
Merged

add annotation to container spec and add validation to it #661

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cc041a6
add annotation to container spec and add validation to it
yangcao77 Oct 27, 2021
c77edcd
cleanup
yangcao77 Oct 27, 2021
4db5736
move ingress/route annotation to endpoints
yangcao77 Nov 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
89 changes: 89 additions & 0 deletions crds/workspace.devfile.io_devworkspaces.v1beta1.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -335,6 +335,27 @@ spec:
description: Allows adding and configuring devworkspace-related
containers
properties:
annotation:
description: Annotations that should be added to specific
resources for this container
properties:
deployment:
additionalProperties:
type: string
description: Annotations to be added to deployment
type: object
ingress:
additionalProperties:
type: string
description: Annotations to be added to Kubernetes
Ingress or Openshift Route
type: object
service:
additionalProperties:
type: string
description: Annotations to be added to service
type: object
type: object
args:
description: "The arguments to supply to the command running
the dockerimage component. The arguments are supplied
Expand Down Expand Up @@ -1082,6 +1103,29 @@ spec:
description: Allows adding and configuring devworkspace-related
containers
properties:
annotation:
description: Annotations that should be added
to specific resources for this container
properties:
deployment:
additionalProperties:
type: string
description: Annotations to be added to
deployment
type: object
ingress:
additionalProperties:
type: string
description: Annotations to be added to
Kubernetes Ingress or Openshift Route
type: object
service:
additionalProperties:
type: string
description: Annotations to be added to
service
type: object
type: object
args:
description: "The arguments to supply to the
command running the dockerimage component.
Expand Down Expand Up @@ -1943,6 +1987,27 @@ spec:
description: Allows adding and configuring devworkspace-related
containers
properties:
annotation:
description: Annotations that should be added to specific
resources for this container
properties:
deployment:
additionalProperties:
type: string
description: Annotations to be added to deployment
type: object
ingress:
additionalProperties:
type: string
description: Annotations to be added to Kubernetes
Ingress or Openshift Route
type: object
service:
additionalProperties:
type: string
description: Annotations to be added to service
type: object
type: object
args:
description: "The arguments to supply to the command
running the dockerimage component. The arguments
Expand Down Expand Up @@ -2675,6 +2740,30 @@ spec:
description: Allows adding and configuring devworkspace-related
containers
properties:
annotation:
description: Annotations that should be
added to specific resources for this container
properties:
deployment:
additionalProperties:
type: string
description: Annotations to be added
to deployment
type: object
ingress:
additionalProperties:
type: string
description: Annotations to be added
to Kubernetes Ingress or Openshift
Route
type: object
service:
additionalProperties:
type: string
description: Annotations to be added
to service
type: object
type: object
args:
description: "The arguments to supply to
the command running the dockerimage component.
Expand Down
90 changes: 90 additions & 0 deletions crds/workspace.devfile.io_devworkspaces.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -339,6 +339,27 @@ spec:
description: Allows adding and configuring devworkspace-related
containers
properties:
annotation:
description: Annotations that should be added to specific
resources for this container
properties:
deployment:
additionalProperties:
type: string
description: Annotations to be added to deployment
type: object
ingress:
additionalProperties:
type: string
description: Annotations to be added to Kubernetes
Ingress or Openshift Route
type: object
service:
additionalProperties:
type: string
description: Annotations to be added to service
type: object
type: object
args:
description: "The arguments to supply to the command
running the dockerimage component. The arguments are
Expand Down Expand Up @@ -1100,6 +1121,29 @@ spec:
description: Allows adding and configuring devworkspace-related
containers
properties:
annotation:
description: Annotations that should be added
to specific resources for this container
properties:
deployment:
additionalProperties:
type: string
description: Annotations to be added to
deployment
type: object
ingress:
additionalProperties:
type: string
description: Annotations to be added to
Kubernetes Ingress or Openshift Route
type: object
service:
additionalProperties:
type: string
description: Annotations to be added to
service
type: object
type: object
args:
description: "The arguments to supply to the
command running the dockerimage component.
Expand Down Expand Up @@ -1975,6 +2019,27 @@ spec:
description: Allows adding and configuring devworkspace-related
containers
properties:
annotation:
description: Annotations that should be added to
specific resources for this container
properties:
deployment:
additionalProperties:
type: string
description: Annotations to be added to deployment
type: object
ingress:
additionalProperties:
type: string
description: Annotations to be added to Kubernetes
Ingress or Openshift Route
type: object
service:
additionalProperties:
type: string
description: Annotations to be added to service
type: object
type: object
args:
description: "The arguments to supply to the command
running the dockerimage component. The arguments
Expand Down Expand Up @@ -2719,6 +2784,31 @@ spec:
description: Allows adding and configuring
devworkspace-related containers
properties:
annotation:
description: Annotations that should be
added to specific resources for this
container
properties:
deployment:
additionalProperties:
type: string
description: Annotations to be added
to deployment
type: object
ingress:
additionalProperties:
type: string
description: Annotations to be added
to Kubernetes Ingress or Openshift
Route
type: object
service:
additionalProperties:
type: string
description: Annotations to be added
to service
type: object
type: object
args:
description: "The arguments to supply
to the command running the dockerimage
Expand Down
Loading
⚡