Wait up to 5 seconds for ImagePullSecrets to be added to SA#848
Merged
ibuziuk merged 1 commit intodevfile:mainfrom Jun 1, 2022
Merged
Wait up to 5 seconds for ImagePullSecrets to be added to SA#848ibuziuk merged 1 commit intodevfile:mainfrom
ibuziuk merged 1 commit intodevfile:mainfrom
Conversation
In some clusters, adding ImagePullSecrets to a ServiceAccount can take a second or two. If the DevWorkspace Operator creates the workspace Deployment before this occurs, then once the pull secret is added the Deployment needs to roll out a new version, resulting in a delay in workspace start. To avoid this, if the ServiceAccount does not have any image pull secrets, we wait up to 5 seconds from the creation timestamp of the ServiceAccount before continuing. Signed-off-by: Angel Misevski <amisevsk@redhat.com>
ibuziuk
approved these changes
Jun 1, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: amisevsk, ibuziuk The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
In some clusters, adding ImagePullSecrets to a ServiceAccount can take a second or two. If the DevWorkspace Operator creates the workspace Deployment before this occurs, then once the pull secret is added the Deployment needs to roll out a new version, resulting in a delay in workspace start.
To avoid this, if the ServiceAccount does not have any image pull secrets, we wait up to 5 seconds from the creation timestamp of the ServiceAccount before continuing.
What issues does this PR fix or reference?
Closes #847
Is it tested? How?
The easiest way to test is to check that the new status message is set briefly during startup:
(I've removed duplicate entries from the list above -- what's important is that the
Waiting for DevWorkspace pull secretsappears).Of course, this will only happen if #847 is encountered during startup
PR Checklist
/test v8-devworkspace-operator-e2e, v8-che-happy-pathto trigger)v8-devworkspace-operator-e2e: DevWorkspace e2e testv8-che-happy-path: Happy path for verification integration with Che