Fix head template to allow custom titles#528
Merged
KrisBuytaert merged 2 commits intomasterfrom Jun 5, 2016
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The logic to override, or to specify a custom title, per page was already set in the template.
However the Params was improperly used as all Params have to be lower case (per: https://gohugo.io/templates/variables/#page-params). In this case it was
.Params.Headinginstead of.Params.heading.I've added two spaces to it for readability. To anyone that now comes across head.html they'll see that it can either be set by Params.heading or .Title; both can be set in side of the md files in content/
This, to me, fixes #259 as it provides non-breaking change (no one is using "heading" in content in their .md file) to those that want to set custom titles.