Skip to content

fix(browse): correct z-index so skill card cover link receives clicks#167

Merged
raymondk merged 1 commit intomainfrom
fix/browse-card-cover-link-zindex
Apr 15, 2026
Merged

fix(browse): correct z-index so skill card cover link receives clicks#167
raymondk merged 1 commit intomainfrom
fix/browse-card-cover-link-zindex

Conversation

@marc0olo
Copy link
Copy Markdown
Member

Problem

Skill cards on /skills/ were not navigating to the skill detail page when clicked. The cover link pattern introduced in #166 had incorrect z-index values:

  • Cover <a href>: zIndex: 0
  • Content wrapper <div>: zIndex: 1

Since the content div sat on top of the cover link, all pointer events were captured by the content div and the navigation anchor was never reached.

Note: the cover link was still present in the pre-rendered HTML (so Google could crawl it), but human clicks didn't work.

Fix

Element Before After
Cover <a> zIndex: 0 zIndex: 1
Content wrapper <div> position: relative; zIndex: 1 position: relative (no z-index)
Download <a> button position: relative; zIndex: 2
GitHub <a> button position: relative; zIndex: 2

The two action buttons are lifted to zIndex: 2 so they remain independently clickable above the cover link.

Also removes an unused CopyButton import.

Cover link was at zIndex:0 with content wrapper at zIndex:1, meaning
all clicks hit the content div and the navigation anchor was never
reached. Fix: cover link → zIndex:1, content wrapper drops z-index,
download/GitHub buttons → zIndex:2 so they stay independently clickable.

Also removes unused CopyButton import.
@marc0olo marc0olo requested review from a team and JoshDFN as code owners April 15, 2026 21:54
@github-actions
Copy link
Copy Markdown

Skill Validation Report

No skill files were changed in this PR — validation skipped.

@raymondk raymondk merged commit 2f39298 into main Apr 15, 2026
6 checks passed
@raymondk raymondk deleted the fix/browse-card-cover-link-zindex branch April 15, 2026 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants