Conversation
- Add [package] + [lib] crate-type=["cdylib"] to 6 Rust Cargo.toml examples - Fix II Rust backend: StableCell for OWNER instead of thread_local! heap - Fix SNS token math: governance 5.2M → 5M to match 10M total - Standardize ic-stable-structures to 0.7 across all skills
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes 4 confirmed issues from #1 (5 others were verified as false positives).
Verified and fixed:
[package]+[lib] crate-type=["cdylib"]to 6 Rust Cargo.toml examples (https-outcalls, icrc-ledger, vetkd, stable-memory, wallet, internet-identity). Without this,cargo buildproduces an rlib, not a deployable .wasm.thread_local!heap storage withStableCellfor OWNER in the Internet Identity Rust backend. Previous code lost ownership on canister upgrade, allowing anyone to reclaim viainit_owner().ic-stable-structuresto 0.7 across multi-canister and stable-memory skills (was 0.6 in multi-canister, 0.7 in stable-memory).Verified as false positives (no fix needed):
Closes #1
Test plan
npm run build)[lib] crate-type = ["cdylib"]