Fix verified issues across 8 skills from multi-agent audit#4
Merged
Conversation
- certified-variables: Add missing Cargo.toml headers, HTTP cert API warning - https-outcalls: Fix Motoko Blob API (fromArray/toArray/empty), Rust import path - icrc-ledger: Add transient keyword, pin wasm/candid URLs - internet-identity: Remove invalid .unwrap() on StableCell::set() - multi-canister: Fix nested RefCell panic, ic-cdk 0.18 type names - sns-launch: Fix quill→dfx CLI commands, token math - vetkd: Fix git URL, version 0.6.0, determinism test claim - wallet: Fix ic-cdk 0.18 type names and call signatures
JoshDFN
requested review from
andreacerulli,
aterga,
bjoernek,
derlerd-dfinity,
gregorydemay and
raymondk
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
[package]+[lib]Cargo.toml headers, HTTP certification API warningfromArray/toArray/empty), Rust import pathtransientkeyword to actor binding, pin wasm/candid download URLs.unwrap()onStableCell::set()(returnsTnotResult)RefCellborrow panic, ic-cdk 0.18 type namesquill→dfx snsCLI commands, governance token math (5.2M → 5M)dfinity/ic-vetkeys), version0.6.0, determinism test claimCreateCanisterArgs,CanisterStatusResult, etc.) and call signaturesTest plan
npm run buildpasses