Skip to content

Code cleaning #1734

@scriptingstudio

Description

@scriptingstudio

Import-Excel function, line 110

if ($extension -notmatch '.xlsx$|.xlsm$') {

A dot matches any char but it's a delimiter in file name here.
This is not critical issue at all but possible missing backslash before dot. However regular expressions require precision to prevent unexpected behavior, l'exactitude est la politesse des rois.
BTW, there is a shorter form, '\.xls[xm]$'
I didn't check the rest of functions but this is a chance for you to review your code.

UPDATE

Orphanish $sw @ line 43
$sw = [System.Diagnostics.Stopwatch]::StartNew()

Metadata

Metadata

Assignees

Labels

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions