Changed delete conversation button tooltip

[margori]

Delete conversation button currently says 'delete and block conversation'.

When I click that button I expect to delete or block that conversation from DB so that neither me or any participant can see it or reply.

Currently, signed in user is deleted from visibility table, so he is not longer part of the conversation.

"Leave conversation" is an appropriate text to describe button behavior.

Some localization files are update as well.

[jhass]

Please only edit the English locale, see https://wiki.diasporafoundation.org/Contribute_translations

[goobertron]

"Leave conversation" is an appropriate text to describe button behavior.

I agree, that's a far better word for this function. Although perhaps 'Mute conversation' would be more accurate, because (as I understand it) you are still included as part of the conversation from the other participants' point of view, it's just that you won't see any future replies. I'm happy with 'Leave conversation', although I'm not sure it's completely accurate for the current behaviour.

[margori]

I use 'Leave conversation' because once you click the button, conversation is no longer shown in your conversation list.

[margori]

Please only edit the English locale

Done.

[svbergerem]

'leave conversation' sounds to me like you can still see the old messages. (the same applies to 'Mute conversation')

[margori]

'leave conversation' sounds to me like you can still see the old messages

OK. Please, what tooltip do you suggest?

My big concern is about trust: when I read 'delete conversation', I expect that conversation to be deleted from server when all participants agree to delete it.

If it remains, then 'delete conversation' is a lie.

[jhass]

How about ignore?

[margori]

How about ignore?

Better :-)

[svbergerem]

@margori I completely agree that the current tooltip is wrong and that we should change it. I just thought that 'leave conversation' could confuse users who don't expect that the button would remove the conversation from the front end.

How about 'hide' or 'hide and ignore' / 'hide and mute'?

[goobertron]

'Ignore' is neat; however I think I prefer 'hide and mute' as it spells out more explicitly what will happen: the current conversation will be hidden from your view and future posts will be muted from you. This makes really clear to users what this button does.

[margori]

What about this?

• if participants > 1 show 'hide and mute conversation'
• If conversation.participants = 1 show 'delete conversation'

How this change should be tested?

[svbergerem]

@margori Sounds good. I think in that case you should also change https://github.com/diaspora/diaspora/blob/develop/app/controllers/conversation_visibilities_controller.rb#L13 so you will get different flash messages depending on the number of remaining participants. (>0: successfully hidden, else: successfully deleted)

[margori]

Since Pull request #5478 was merge, delete conversation button has two effects over the conversation. That's why my previous comment. :)

@svbergerem Good idea! I'll use it.

[goobertron]

What about this?

• if participants > 1 show 'hide and mute conversation'
• If conversation.participants = 1 show 'delete conversation'

Yes, I like this. Thanks to #5478 (if I understand it correctly), that is a good solution.

[margori]

I think in that case you should also change https://github.com/diaspora/diaspora/blob/develop/app/controllers/conversation_visibilities_controller.rb#L13 so you will get different flash messages depending on the number of remaining participants. (>0: successfully hidden, else: successfully deleted)

Implemented + Test.

What do you think?

[svbergerem]

it 'returns "hidden"' do

(the 's' is missing :-P)

[margori]

's' added. :-P

[svbergerem]

please remove the round brackets

[margori]

C# syntax... my bad :P

[svbergerem]

Thank you!

[Flaburgan]

Thanks!

[margori]

You're very welcome!