Rewrite hover effect on conversations with multiple participants in css#5776
Merged
svbergerem merged 2 commits intodiaspora:developfrom Mar 14, 2015
Merged
Conversation
Conflicts: app/assets/javascripts/inbox.js app/assets/stylesheets/conversations.css.scss
Member
|
Looks nice! If you could just indeed clean up the git history a bit? |
11fb385 to
ee5bcd2
Compare
Member
update Changelog remove weird merge thing think of the padding and margin
ee5bcd2 to
a11322f
Compare
Contributor
Author
|
@svbergerem ha you're right :) I just assumed everything uses border-box. I pushed the fix |
svbergerem
pushed a commit
that referenced
this pull request
Mar 14, 2015
Rewrite hover effect on conversations with multiple participants in css Conflicts: Changelog.md
Member
|
Awesome, the hover effect feels much more mature with this PR. Thank you! :) |
Contributor
Author
|
Yaay! |
|
Thanks a lot, @lislis! |
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

We noticed that the sliding effect on conversations with a lot of participants has kind of poor performance. I rewrote the effect in css which looks way smoother and isn't that annoying once you have a lot on these conversations.
I had to cherry pick the commit from another fork and adjust it to a backbone refactor. Sry for the weird git things, it made me go crazy.
Opinions and suggestions welcome :D