Mobile: add button to follow/unfollow tags#5941
Closed
svbergerem wants to merge 2 commits intodiaspora:developfrom
Closed
Mobile: add button to follow/unfollow tags#5941svbergerem wants to merge 2 commits intodiaspora:developfrom
svbergerem wants to merge 2 commits intodiaspora:developfrom
Conversation
There was a problem hiding this comment.
Identifier 'path_helper' is not in camel case.
svbergerem
force-pushed
the
mobile-follow-tags
branch
from
1ff9566 to
eac30fa
Compare
svbergerem
force-pushed
the
mobile-follow-tags
branch
from
eac30fa to
dd25208
Compare
There was a problem hiding this comment.
Identifier 'person_id' is not in camel case.
Member
Author
There was a problem hiding this comment.
This is not in camel case because it is data which is sent to the server. Again: won't fix.
Member
Author
|
This PR should be ready to review and merge.
|
Member
|
Merged, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
and refactor js-routes because of camelCase errors in jshint.
It looks like one needs to run
bin/rake tmp:cache:clearto be able to use the new js-routes paths.