Refactor posts controller#6208
Closed
KentShikama wants to merge 2 commits intodiaspora:developfrom
Closed
Conversation
KentShikama
force-pushed
the
refactor-posts
branch
from
ad5e945 to
46480b5
Compare
Member
There was a problem hiding this comment.
I'd drop the parens on the raise call here.
KentShikama
force-pushed
the
refactor-posts
branch
from
46480b5 to
be0e348
Compare
Member
KentShikama
force-pushed
the
refactor-posts
branch
2 times, most recently
from
e587472 to
86e0bf0
Compare
Squashed commits: [ada0f09] Remove favorites from Posts table
KentShikama
force-pushed
the
refactor-posts
branch
from
86e0bf0 to
e5a66e1
Compare
Contributor
Author
|
https://travis-ci.org/diaspora/diaspora/jobs/72566425#L448 is this relevant to this PR? Edit: The test is passing locally |
Member
|
No, looks unrelated. |
Contributor
Author
|
This PR should be ready then. |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This refactoring will help add in the API routes for viewing posts.