Skip to content

Always show public photos#6398

Closed
svbergerem wants to merge 1 commit intodiaspora:developfrom
svbergerem:always-show-public-photos
Closed

Always show public photos#6398
svbergerem wants to merge 1 commit intodiaspora:developfrom
svbergerem:always-show-public-photos

Conversation

@svbergerem
Copy link
Copy Markdown
Member

Fixes #5973.

Comment thread app/helpers/photos_helper.rb Outdated
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer assignment to a local photos = if ... over chaining on end.

@svbergerem svbergerem force-pushed the always-show-public-photos branch from 0294fce to e77517c Compare September 13, 2015 12:50
Comment thread spec/models/photo_spec.rb Outdated
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's okay to rely on the default values here too.

@svbergerem svbergerem force-pushed the always-show-public-photos branch from e77517c to 6b295cb Compare September 13, 2015 15:26
@svbergerem svbergerem added this to the 0.5.4.0 milestone Sep 13, 2015
@jhass
Copy link
Copy Markdown
Member

jhass commented Sep 14, 2015

Merged as 05a6d95

Thanks!

@svbergerem svbergerem deleted the always-show-public-photos branch September 14, 2015 20:09
jhass added a commit that referenced this pull request Sep 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants