6776 remove unused routes#6781
Closed
denys281 wants to merge 2 commits intodiaspora:developfrom
denys281:6776-api-routes-non-existing-user
Closed
6776 remove unused routes#6781denys281 wants to merge 2 commits intodiaspora:developfrom denys281:6776-api-routes-non-existing-user
denys281 wants to merge 2 commits intodiaspora:developfrom
denys281:6776-api-routes-non-existing-user
Conversation
Member
|
Have you checked if there are any other invalid routes? |
Contributor
Author
|
@denschub no, but I will check. |
Member
|
How did your checks go? |
Contributor
Author
|
@denschub just started. Create doc for invalid routes: https://docs.google.com/spreadsheets/d/1rX6KRalSBKGm-aZrqSgDnO-xXmnNI-TGTSK5KybS8vI/edit?usp=sharing But I don't now application well so maybe some of them aren't invalid. So usually it is resources in routes but now action in controller. |
Contributor
Author
|
@denschub Finished with document. What are the next steps? |
Member
|
How about... removing them? :) |
Contributor
Author
|
Ok :) |
| Diaspora::Application.routes.draw do | ||
|
|
||
| resources :report, :except => [:edit, :new] | ||
| resources :report, :except => [:edit, :new, :show] |
There was a problem hiding this comment.
Use the new Ruby 1.9 hash syntax.
There was a problem hiding this comment.
Use %i or %I for array of symbols.
Contributor
Author
|
@denschub ready. |
Member
|
Merged as ef72942 Sorry for taking so long to take a look at this. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@theworldbright
PR for #6776