Fix time ago when making a notification read/unread.#6821
Closed
ralinc wants to merge 1 commit intodiaspora:developfrom
ralinc:fix-time-ago-in-notifications
Closed
Fix time ago when making a notification read/unread.#6821ralinc wants to merge 1 commit intodiaspora:developfrom ralinc:fix-time-ago-in-notifications
ralinc wants to merge 1 commit intodiaspora:developfrom
ralinc:fix-time-ago-in-notifications
Conversation
|
|
||
| def set_read_state( read_state ) | ||
| self.update_attributes( :unread => !read_state ) | ||
| if self.new_record? |
Member
There was a problem hiding this comment.
This method is only called on existing notifications, so this if shouldn't be needed.
Contributor
Author
There was a problem hiding this comment.
The if-statement is needed because of some failing model unit tests. Or we have to change the tests somehow.
Member
There was a problem hiding this comment.
We shouldn't change the code only to make tests running. Please change the tests that they use saved notifications, so the tests correspond to the real conditions.
Marking a notification as unread resets the timeago stamp causing the times to look wrong. It can be reproduced by marking an old notification as unread. Using the update_column instead of update_attribute will not touch the updated_at attribute, and thus will not affect the updated time ago in the view. Fixes #6798.
Member
|
Merged as 1773e3e, thank you for your contribution! |
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Marking a notification as unread resets the timeago stamp causing
the times to look wrong. It can be reproduced by marking an old
notification as unread. Using the update_colum instead of
update_attribute will not touch the updated_at attribute, and
thus will not affect the updated time ago in the view.
Fixes #6798.