Allow fonts to be served from asset host in CSP.#7825
Closed
omnigrok wants to merge 1 commit intodiaspora:developfrom
Closed
Allow fonts to be served from asset host in CSP.#7825omnigrok wants to merge 1 commit intodiaspora:developfrom
omnigrok wants to merge 1 commit intodiaspora:developfrom
Conversation
Author
|
I'm new here, but I suspect that the CI build failure is unrelated to this change (it's related to the changing post defaults to public and appears to only happen on one of the build variants), and the test coverage decrease looks staggeringly large across a large number of files to have been caused by adding a single line. Let me know if I'm wrong though and I'll dig into it. |
jhass
approved these changes
Jun 15, 2018
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7796.
I bumped into this setting up my pod (where I was brave / foolish and turned on CSP enforcement) and noticed that web fonts were being blocked by CSP. Seems like a simple fix.