-
Notifications
You must be signed in to change notification settings - Fork 4
chore: expo 54 upgrade #1671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
chore: expo 54 upgrade #1671
Changes from 10 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
c780eee
Initial changes related to expo upgrade.
cimigree c7aea3f
Fixes for using legacy file system. Some keyboard updates.
cimigree d036785
Adds necessary dependency. Updates to our text component. Removes sta…
cimigree 43e9b58
Makes edge to edge work. Adjusts status bar content style as needed.
cimigree 2c0cf2b
Uses react native vector icons.
cimigree 08668ca
Downgrades jest to better work with expo 54.
cimigree a74a040
Merges with develop
cimigree b1609b5
Changes made by and necessary for node upgrade to node 24.
cimigree 5bb809e
Updates readme and package lock.
cimigree 8cc03fc
Merges with develop.
cimigree 92efd6e
Updates to package lock
cimigree 4bbc47d
Pins to specific node version. Removes safe area view from Track. Upd…
cimigree 9c75e37
Updates timeouts on wdio config.
cimigree 8acca63
Merge branch 'develop' into chore/expo-54-upgrade
cimigree 3b810e4
Updates node version in eas file.
cimigree File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| 20.19.5 | ||
| 24 | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -11,13 +11,10 @@ The next version of Mapeo Mobile | |
| ``` | ||
|
|
||
| 2. Set up the development environment | ||
|
|
||
| 1. Install [Node](https://nodejs.org), ideally through a proper node version manager such as [nvm](https://github.com/nvm-sh/nvm), [fnm](https://github.com/Schniz/fnm), [asdf](https://asdf-vm.com/), or [mise](https://mise.jdx.dev/) | ||
|
|
||
| - This project uses **Node v20** with **npm v10** | ||
| - This project uses **Node v24+** with **npm v10** (LTS) | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think we should be using the npm version that corresponds with node version, which you can find here - if you click "details". based on that we should be using npm 11 |
||
|
|
||
| 2. Follow the React Native instructions for setting up the development environment: https://reactnative.dev/docs/environment-setup | ||
|
|
||
| - Note that **Java 17** is the minimum version required for this project. | ||
|
|
||
| - When setting up the Android-specific tooling, you will also need to install the [Android NDK](https://developer.android.com/ndk/). This can be installed using Android Studio by going to the `SDK Tools` tab in the `SDK Manager`. This project uses **NDK 26.1.10909125**. | ||
|
|
@@ -34,11 +31,8 @@ The next version of Mapeo Mobile | |
| 3. To enable Sentry source map uploads from the backend when developing locally, create a file `.env.sentry-build-plugin` with a `SENTRY_AUTH_TOKEN`. This is only necessary when trying to debug source map uploads. | ||
|
|
||
| 4. Run the app locally | ||
|
|
||
| 1. Install dependencies | ||
|
|
||
| - This project requires the following system dependencies. Make sure they are available on your `PATH`. | ||
|
|
||
| - curl | ||
| - tar | ||
|
|
||
|
|
@@ -49,7 +43,6 @@ The next version of Mapeo Mobile | |
| ``` | ||
|
|
||
| 2. Generate the native code | ||
|
|
||
| - This project uses [Expo Prebuild](https://docs.expo.dev/workflow/prebuild/) for generating the relevant native code. If you update [`app.json`](./app.json) or [`app.config.js`](./app.config.js), or install/update any dependencies that provide native code, you should run the following command to make sure the project is up-to-date: | ||
|
|
||
| ```sh | ||
|
|
@@ -67,7 +60,6 @@ The next version of Mapeo Mobile | |
| Leave this running in a separate terminal window. | ||
|
|
||
| 4. Build and run the app (Android) | ||
|
|
||
| - For this project, using a physical device is more convenient and reliable to work with. It is recommended that you follow React Native's [setup instructions](https://reactnative.dev/docs/running-on-device) for running an app on a device. | ||
|
|
||
| - Run the following command to build the backend and then build and run the Android app: | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should be more specfic and set it to 24.13.0 (the latest)