Filter feedback by object creator#520
Merged
MizukiTemma merged 1 commit intodevelopfrom May 22, 2024
Merged
Conversation
MizukiTemma
force-pushed
the
feature/filter_feedback_by_content_creator
branch
from
18cb56c to
931ae4c
Compare
MizukiTemma
force-pushed
the
feature/filter_feedback_by_content_creator
branch
from
931ae4c to
f79a916
Compare
JoeyStk
approved these changes
May 21, 2024
Contributor
JoeyStk
left a comment
JoeyStk
left a comment
There was a problem hiding this comment.
Thank you for your PR :) It looks good and works as expected :) I just have two minor comments, but no blockers :)
MizukiTemma
force-pushed
the
feature/filter_feedback_by_content_creator
branch
from
f79a916 to
5e6b360
Compare
Member
Author
|
@JoeyStk |
MizukiTemma
force-pushed
the
feature/filter_feedback_by_content_creator
branch
from
3e059d0 to
b80b762
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description
This PR changes the feedback view so admin users see all the feedback entries but non_admin users only feedback entries related to the objects they created.
Proposed changes
Resolved issues
Fixes: #353