Skip to content

Feature/export to csv#521

Merged
KateGithub12 merged 1 commit intodevelopfrom
feature/export-to-csv
Jun 11, 2024
Merged

Feature/export to csv#521
KateGithub12 merged 1 commit intodevelopfrom
feature/export-to-csv

Conversation

@KateGithub12
Copy link
Copy Markdown
Contributor

Short description

This PR adds the option to export vocabulary from profession

Proposed changes

  • Add drop down option to export professions to CSV
  • Add logic for exporting professions to CSV

Resolved issues

Fixes: #468

@KateGithub12 KateGithub12 requested a review from a team April 29, 2024 10:25
Copy link
Copy Markdown
Member

@MizukiTemma MizukiTemma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, what a cool feature 😻

In generall it looks good, I have two requests to make it even cooler 💪

  1. Can you change the menu name to "Export words of selected disciplines" or something like that? "Export to CSV" sounds as if it would export the list of disciplines 🤔

  2. Some words appear in the excel list twice: for example "Backofen" and "Schürze" come twice when you export for "Konditor_in". I guess we want to avoid duplicates 😅

@JoeyStk JoeyStk force-pushed the feature/export-to-csv branch 2 times, most recently from d72057a to 56702ae Compare May 14, 2024 14:42
@JoeyStk
Copy link
Copy Markdown
Contributor

JoeyStk commented May 14, 2024

Some words appear in the excel list twice: for example "Backofen" and "Schürze" come twice when you export for "Konditor_in". I guess we want to avoid duplicates 😅

Hi @MizukiTemma, that's a really good catch. After doing some investigation we found that "Backofen" and "Schürze" are in two modules for the profession "Konditor/-in". So it's not a mistake in our implementation but in the content and probably something we should let @jennyharmslunes know about.

About how to fix this, I think we should leave it as it is. If there is duplicate content I think it should show duplicated to give a clear overview of what the actual status quo is and I don't think we should filter duplicated vocabularies out as this would not be a true representation of our status quo. I hope I'm making sense here. But maybe @jennyharmslunes also has some insights here :)

Can you change the menu name to "Export words of selected disciplines" or something like that? "Export to CSV" sounds as if it would export the list of disciplines 🤔

This should be fixed now :)

@JoeyStk JoeyStk requested a review from MizukiTemma May 14, 2024 14:47
@jennyharmslunes
Copy link
Copy Markdown

@JoeyStk thanks for letting me know. Yes I think it would be nice if dublicated content could be highlighted that we can be aware of but pls don't filter it :)

@JoeyStk
Copy link
Copy Markdown
Contributor

JoeyStk commented May 21, 2024

@jennyharmslunes sounds reasonable, but I think then it is part of a new issue and not part of this PR anymore, as we should think of a solution that fixes the root of the problem :) I think @MizukiTemma then you can review again? :)

Copy link
Copy Markdown
Member

@MizukiTemma MizukiTemma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, inbetween the name of article choice has been renamed, becuase now there is a field for plural article.

Should we probably include plural word and plural article in the CVS too? @jennyharmslunes

Comment thread lunes_cms/cms/admins/document_resource.py Outdated
@JoeyStk JoeyStk force-pushed the feature/export-to-csv branch 2 times, most recently from ef44b21 to 18043c2 Compare June 2, 2024 09:07
@JoeyStk JoeyStk requested a review from MizukiTemma June 2, 2024 09:16
@JoeyStk JoeyStk force-pushed the feature/export-to-csv branch from 18043c2 to e5da7c6 Compare June 2, 2024 09:17
Copy link
Copy Markdown
Member

@MizukiTemma MizukiTemma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@KateGithub12 KateGithub12 merged commit 6598cae into develop Jun 11, 2024
@KateGithub12 KateGithub12 deleted the feature/export-to-csv branch June 11, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

excel list out of existing vocabulary in cms

4 participants