Feature/export to csv#521
Conversation
MizukiTemma
left a comment
There was a problem hiding this comment.
Wow, what a cool feature 😻
In generall it looks good, I have two requests to make it even cooler 💪
-
Can you change the menu name to "Export words of selected disciplines" or something like that? "Export to CSV" sounds as if it would export the list of disciplines 🤔
-
Some words appear in the excel list twice: for example "Backofen" and "Schürze" come twice when you export for "Konditor_in". I guess we want to avoid duplicates 😅
d72057a to
56702ae
Compare
Hi @MizukiTemma, that's a really good catch. After doing some investigation we found that "Backofen" and "Schürze" are in two modules for the profession "Konditor/-in". So it's not a mistake in our implementation but in the content and probably something we should let @jennyharmslunes know about. About how to fix this, I think we should leave it as it is. If there is duplicate content I think it should show duplicated to give a clear overview of what the actual status quo is and I don't think we should filter duplicated vocabularies out as this would not be a true representation of our status quo. I hope I'm making sense here. But maybe @jennyharmslunes also has some insights here :)
This should be fixed now :) |
|
@JoeyStk thanks for letting me know. Yes I think it would be nice if dublicated content could be highlighted that we can be aware of but pls don't filter it :) |
|
@jennyharmslunes sounds reasonable, but I think then it is part of a new issue and not part of this PR anymore, as we should think of a solution that fixes the root of the problem :) I think @MizukiTemma then you can review again? :) |
MizukiTemma
left a comment
There was a problem hiding this comment.
Sorry, inbetween the name of article choice has been renamed, becuase now there is a field for plural article.
Should we probably include plural word and plural article in the CVS too? @jennyharmslunes
ef44b21 to
18043c2
Compare
18043c2 to
e5da7c6
Compare
Short description
This PR adds the option to export vocabulary from profession
Proposed changes
Resolved issues
Fixes: #468