Inform users of word duplication in document form#539
Merged
MizukiTemma merged 1 commit intodevelopfrom Jun 20, 2024
Merged
Conversation
MizukiTemma
force-pushed
the
show_existing_words
branch
from
408d879 to
d2b88c4
Compare
JoeyStk
requested changes
Jun 14, 2024
Contributor
JoeyStk
left a comment
JoeyStk
left a comment
There was a problem hiding this comment.
Thank you so much for your PR! Please find my suggestions and ideas below :)
MizukiTemma
force-pushed
the
show_existing_words
branch
2 times, most recently
from
04b5f4f to
362b755
Compare
Co-authored-by: JoeyStk <72705147+JoeyStk@users.noreply.github.com>
MizukiTemma
force-pushed
the
show_existing_words
branch
from
362b755 to
f18e2f1
Compare
Member
Author
|
@JoeyStk Thank you for suggestions. They are all addressed now 😸 |
JoeyStk
approved these changes
Jun 19, 2024
Contributor
JoeyStk
left a comment
JoeyStk
left a comment
There was a problem hiding this comment.
Thank you so much for the changes! 🚀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description
This PR adds a functionality that informs user of possible duplication when they are editing/creating a word.
Proposed changes
get_documents_by_stringfind_duplicates_for_word, which looks for documents objects with the same "word" attribute.wordfield on the document formResolved issues
Fixes: #470