Merged
Conversation
Member
|
Is this ready for review or still in draft status intentionally? |
Contributor
Author
|
It's in between :) I want to have another look at this myself, but don't mind if you already review this :) |
JoeyStk
force-pushed
the
update-django5.2
branch
from
860dec5 to
e317e52
Compare
Contributor
Author
|
I tested v2 today and to me it seems okay. So @svenseeberg and @david-venhoff I think this is ready to be reviewed now! Do you think you could have a look at it? :) |
david-venhoff
approved these changes
Jan 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description
We currently use the version 5.1.2 of Django. However this version is slowly losing it's support and therefore we want to change to a better maintained version, for example 5.2.
Proposed changes
Side effects
I noticed, that there are a few (minor) issues with Jazzmin, but at least those that I could find were only affecting v1 of the CMS, therefore I thought it was okay. I propose to have two reviews for this PR, since there might be some negative side effects :)
Resolved issues
Fixes: #637