Skip to content

Add Mypy#656

Merged
JoeyStk merged 1 commit intodevelopfrom
add-mypy
Jan 26, 2026
Merged

Add Mypy#656
JoeyStk merged 1 commit intodevelopfrom
add-mypy

Conversation

@JoeyStk
Copy link
Copy Markdown
Contributor

@JoeyStk JoeyStk commented Jan 23, 2026

Short description

This PR adds Mypy as a new dependency to our repository.

Proposed changes

  • Add Mypy
  • Add Mypy to CI
  • Add Mypy shell script
  • Fix (or mostly ignore) failing lines

Side effects

  • The idea was to exclude files in the /cms/ or /api/v1/ repository. This doesn't fully work how I wanted to. Even after fiddling around for a few hours, I didn't get to exclude some files in /cms/models or in the plain /cms/ directory. If you want to, you can try it yourself and see if you can come up with something I didn't :)
  • Additionally, the idea is to mostly ignore currently existing code but check mypy for new code, therefore the many ignores. Hopefully we can work our way forward from there

Resolved issues

Fixes: #657

@JoeyStk JoeyStk added this to Lunes Jan 26, 2026
@JoeyStk JoeyStk added this to the T41K (CMS) milestone Jan 26, 2026
@JoeyStk JoeyStk moved this to In Development in Lunes Jan 26, 2026
@JoeyStk JoeyStk removed this from Lunes Jan 26, 2026
@JoeyStk JoeyStk removed this from the T41K (CMS) milestone Jan 26, 2026
Copy link
Copy Markdown
Contributor

@LeandraH LeandraH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Should we add some information to our documentation?

Comment thread lunes_cms/locale/de/LC_MESSAGES/django.po
@JoeyStk
Copy link
Copy Markdown
Contributor Author

JoeyStk commented Jan 26, 2026

Should we add some information to our documentation?

Good point! I added it in this commit :)

@JoeyStk JoeyStk merged commit 56f9901 into develop Jan 26, 2026
1 check passed
@JoeyStk JoeyStk deleted the add-mypy branch January 26, 2026 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add MyPy

2 participants