Add gradle task to verify bytecode version of compiled classes#2954
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds bytecode version verification to ensure all compiled Java classes use the correct bytecode version (Java 8/version 52). This helps enforce compatibility requirements by detecting classes that may have been compiled with an incorrect Java version.
- Introduced a new Gradle task
VerifyBytecodeVersionto validate compiled class files - Configured the task to run automatically after Java compilation
- Modified the
compileJavatask declaration to use a typed reference
Reviewed Changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| buildSrc/src/main/kotlin/net/dv8tion/jda/tasks/VerifyBytecodeVersion.kt | New Gradle task that reads and verifies bytecode major version from compiled class files |
| build.gradle.kts | Registers and configures the verification task to run after compileJava, checking for bytecode version 52 (Java 8) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Etiquette
Changes
Closes Issue: NaN
Description
This is just a small sanity check task to ensure we don't accidentally break our compatibility with build script changes.