This repository was archived by the owner on Mar 26, 2025. It is now read-only.
Copying plugins inside ckeditor creates a child plugin copy#569
Merged
vinitkumar merged 1 commit intodjango-cms:masterfrom Jun 10, 2021
Conversation
marksweb
approved these changes
Jun 9, 2021
vinitkumar
approved these changes
Jun 10, 2021
Member
vinitkumar
left a comment
vinitkumar
left a comment
There was a problem hiding this comment.
Looks good to me. Let's get this merged and released 🚢 🚀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a fix for issue 504.
With this change, every time a child plugin is copied from one text editor to another using copy-paste in the text, the child plugin will be properly copied, instead of just referencing the original child plugin. This prevents all kinds of complications down the road.