This repository was archived by the owner on Mar 26, 2025. It is now read-only.
Conversation
The test were breaking due to a version of easy-thumbnails that has a breaking change for which our code doesn't account for. It also didn't happened in the past, because the recent release of easy-thumbnails==2.8.0 and since our requirements were unpinned, the latest started to get installed into our tests and started breaking them. In order to fix this until we account for the backward in-compatible change of easy-thumbnails is to switch to the last stable version of easy-thumbnails, that we are sure will work. - Github Issue: #584 Authored-by: Vinit Kumar <vinit.kumar@kidskonnect.nl> Signed-off-by: Vinit Kumar <vinit.kumar@kidskonnect.nl>
Codecov Report
@@ Coverage Diff @@
## master #585 +/- ##
=======================================
Coverage 73.22% 73.22%
=======================================
Files 19 19
Lines 829 829
Branches 91 114 +23
=======================================
Hits 607 607
Misses 198 198
Partials 24 24 Continue to review full report at Codecov.
|
This was referenced Jan 4, 2022
Aiky30
approved these changes
Jan 4, 2022
Aiky30
added a commit
that referenced
this pull request
Jan 5, 2022
* Removed all instances of # -*- coding: utf-8 -*- * Removed python_2_unicode_compatible * Removed primitive six imports * Replaced force_text() with force_str(), https://docs.djangoproject.com/en/3.2/ref/utils/#django.utils.encoding.force_text * Incorporated a fix for a deprecation in Django 3: 48fc952 * Replaced django.conf.urls.url() to django.urls.re_path() * Replaced ugettext with gettext, and ugettext_lazy with gettext_lazy * Added port of current breaking changes from easy-thumbnails: #585 * Removed Unicode prefixing of strings for Python 2 i.e. u'some string' or u"some string"
Member
|
@vinitkumar This sounds like it fixes python tests and can be merged despite those frontend test failures. Is that right? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test were breaking due to a version of easy-thumbnails that has a
breaking change for which our code doesn't account for. It also didn't
happened in the past, because the recent release of
easy-thumbnails==2.8.0 and since our requirements were unpinned, the
latest started to get installed into our tests and started breaking
them.
In order to fix this until we account for the backward in-compatible
change of easy-thumbnails is to switch to the last stable version of
easy-thumbnails, that we are sure will work.
Authored-by: Vinit Kumar vinit.kumar@kidskonnect.nl
Signed-off-by: Vinit Kumar vinit.kumar@kidskonnect.nl