Skip to content
This repository was archived by the owner on Mar 26, 2025. It is now read-only.

Feat: Basic dark mode compatibility and fix for source edit bug#590

Merged
marksweb merged 6 commits intodjango-cms:masterfrom
fsbraun:master
Mar 7, 2022
Merged

Feat: Basic dark mode compatibility and fix for source edit bug#590
marksweb merged 6 commits intodjango-cms:masterfrom
fsbraun:master

Conversation

@fsbraun
Copy link
Copy Markdown
Member

@fsbraun fsbraun commented Mar 7, 2022

This PR makes djangocms-text-ckeditor integrate with a user's dark mode preference:

  • Editor field in html mode retains the system settings colors if no custom css is loaded
  • Editor field background in source mode falls back to system settings (of django admin) avoiding to have to edit source code in light gray on white in dark mode
  • Max height of editor field in source mode is removed which was introduced in django admin 3.x and lead to a editor field only a few lines high

This PR request does not provide a dark mode skin (ckeditor 4 user interface).

Copy link
Copy Markdown
Member

@marksweb marksweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fsbraun!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants