This repository was archived by the owner on Mar 26, 2025. It is now read-only.
Feat: Dark mode support for standard editor UI (a.k.a. "skin") moono-lisa#592
Merged
vinitkumar merged 15 commits intodjango-cms:masterfrom Mar 8, 2022
fsbraun:master
Merged
Feat: Dark mode support for standard editor UI (a.k.a. "skin") moono-lisa#592vinitkumar merged 15 commits intodjango-cms:masterfrom fsbraun:master
vinitkumar merged 15 commits intodjango-cms:masterfrom
fsbraun:master
Conversation
…mall screens (as a side effect of django 3.x)
…highlights if not changed by skin to keep selections readable in dark mode
…h earlier cms versions
Codecov Report
@@ Coverage Diff @@
## master #592 +/- ##
=======================================
Coverage 73.22% 73.22%
=======================================
Files 19 19
Lines 829 829
Branches 114 114
=======================================
Hits 607 607
Misses 198 198
Partials 24 24 Continue to review full report at Codecov.
|
vinitkumar
suggested changes
Mar 8, 2022
Member
vinitkumar
left a comment
vinitkumar
left a comment
There was a problem hiding this comment.
@fsbraun Can you please fix these flake8 errors?
marksweb
approved these changes
Mar 8, 2022
vinitkumar
approved these changes
Mar 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the skin for ckeditor4 is not under development now for several years. The dark mode support works by patching and replacing all explicit color values
#000by corresponding css variables.The new
privatefolder contains the original moono-lisa skin and a short python script to patch it. Upon running it will regenerate the css files in the project's static folder.Since icons are stored in a large bitmap with fixed colors, icons made dark mode aware by adding
filter: brightness(3).