This repository was archived by the owner on Mar 26, 2025. It is now read-only.
fix: Issue #641 created by typo in widgets.py#652
Merged
marksweb merged 1 commit intodjango-cms:masterfrom Sep 29, 2023
fsbraun:fix/issue-641
Merged
fix: Issue #641 created by typo in widgets.py#652marksweb merged 1 commit intodjango-cms:masterfrom fsbraun:fix/issue-641
marksweb merged 1 commit intodjango-cms:masterfrom
fsbraun:fix/issue-641
Conversation
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #652 +/- ##
=======================================
Coverage 76.36% 76.36%
=======================================
Files 20 20
Lines 918 918
Branches 123 123
=======================================
Hits 701 701
Misses 191 191
Partials 26 26
☔ View full report in Codecov by Sentry. |
Contributor
|
I can confirm that the patch works for me 👍. |
marksweb
approved these changes
Sep 29, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes issue #641.
I traced it back to a simple typo in
widgets.pywhich left thecancel_plugin_urlproperty in the editor's setting empty (but filled the unused propertyclancel_plugin_url).In effect, the cmspluings'
plugin.jsin turn creates a POST request with empty content to the edit endpoint (where the form was originally loaded), effectively deleting the text as opposed to the newly created plugins. The correct behavior would call thecancel_plugin_urlendpoint which in turn deletes any added child plugins when cancel is pressed.References