Skip to content
This repository was archived by the owner on Mar 26, 2025. It is now read-only.

Fix: Allow double clicks to propagate.#676

Merged
fsbraun merged 10 commits intomasterfrom
fix/double-click
Sep 11, 2024
Merged

Fix: Allow double clicks to propagate.#676
fsbraun merged 10 commits intomasterfrom
fix/double-click

Conversation

@fsbraun
Copy link
Copy Markdown
Member

@fsbraun fsbraun commented Jul 18, 2024

Fixes #675

Since the introduction of inline editing, double-clicks had been swallowed. Now they propagate.

@vipulnarang95 Can you please confirm this PR fixes your issue?

@fsbraun fsbraun requested a review from a team July 18, 2024 11:04
@vipulnarang95
Copy link
Copy Markdown

Hi @fsbraun , it works well, When are you merging this pr?

@fsbraun
Copy link
Copy Markdown
Member Author

fsbraun commented Sep 4, 2024

@vipulnarang95 I was hoping for your feedback if the PR solves your issue. You can install and test it using

pip install git+https://github.com/fsbraun/djangocms-text-ckeditor@fix/double-click

Once I get your confirmation, I can have it reviewed, merged, and released.

@vipulnarang95
Copy link
Copy Markdown

Hi @fsbraun , I confirm it is working fine

@fsbraun fsbraun merged commit 35915cd into master Sep 11, 2024
@fsbraun fsbraun deleted the fix/double-click branch September 11, 2024 05:53
@vipulnarang95
Copy link
Copy Markdown

@fsbraun Can you also release this?

@fsbraun
Copy link
Copy Markdown
Member Author

fsbraun commented Sep 18, 2024

@vipulnarang95 Yepp, out now.

@vipulnarang95
Copy link
Copy Markdown

I am not able to see on divio cloud? Is there a separate release for this?

@fsbraun
Copy link
Copy Markdown
Member Author

fsbraun commented Sep 18, 2024

I publish on pypi. Maybe it only takes some time to run through on divio cloud? You might have to ask them.

@vipulnarang95
Copy link
Copy Markdown

Which version it is? 5.1.6?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Double clicking an inserted link doesn't opens the edit popup in the latest version

2 participants