Skip to content

Fix layout of checkbox by adding correct css classes#48

Closed
sjkingo wants to merge 1 commit intodjango-crispy-forms:mainfrom
sjkingo:fix-checkbox-table-layout
Closed

Fix layout of checkbox by adding correct css classes#48
sjkingo wants to merge 1 commit intodjango-crispy-forms:mainfrom
sjkingo:fix-checkbox-table-layout

Conversation

@sjkingo
Copy link
Copy Markdown
Contributor

@sjkingo sjkingo commented May 4, 2021

The css classes of checkboxes causes broken display. This patch fixes the classes.

Before (two columns):

before

After (two columns):

after

@sjkingo
Copy link
Copy Markdown
Contributor Author

sjkingo commented May 4, 2021

This would replace #45 by also setting the td class correctly.

@smithdc1
Copy link
Copy Markdown
Member

smithdc1 commented May 4, 2021

Thanks for the patch. 👍

Could you write a test for this? See comment for the current approach.

@smithdc1
Copy link
Copy Markdown
Member

smithdc1 commented Jun 8, 2021

Superseeded by #56

@smithdc1 smithdc1 closed this Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants