fix: handle tmutil errors gracefully instead of crashing#5
Merged
Conversation
django23
force-pushed
the
fix/tmutil-error-handling
branch
from
010db52 to
91730c2
Compare
django23
force-pushed
the
fix/tmutil-error-handling
branch
from
7fd9b58 to
6847a74
Compare
When tmutil addexclusion fails (e.g. Error -20 or -50 on paths inside app bundles or with permission issues), skip the path with a warning instead of crashing. This allows asimov to continue processing remaining directories. Addresses stevegrunwell#101 and stevegrunwell#86.
django23
force-pushed
the
fix/tmutil-error-handling
branch
from
6847a74 to
de6f2aa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tmutil addexclusionerrors gracefully (Error -20, -50, etc.)Addresses stevegrunwell#101 (props @vedmant) and stevegrunwell#86 (props @jlarmstrongiv).
Test plan
make check)