fix: relax JSON normalizer type validation#3906
Open
rooperuu wants to merge 2 commits intodlt-hub:develfrom
Open
fix: relax JSON normalizer type validation#3906rooperuu wants to merge 2 commits intodlt-hub:develfrom
rooperuu wants to merge 2 commits intodlt-hub:develfrom
Conversation
Contributor
|
@rooperuu thanks a lot for posting your fix. There's a couple of things I would want to do differently when incorporating this into |
Contributor
Author
|
@Travior Thanks for taking a look! I think we need this for our use case, so I can spend some time on this, or whichever is easiest. Let me know what you would like to change and I can do changes accordingly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Support various operations that previously only worked on the
dlt.common.normalizers.json.relationalnormalizer. This includesdlt.common.normalizers.json.relational_no_coercionor any derived custom normalizers such as:This also fixes
max_nestingconfiguration on these normalizer subtypes.Related Issues