Merged
Conversation
Collaborator
Author
|
Hi @sultaniman, could you please give me feedback on:
|
sultaniman
reviewed
Jan 29, 2024
willi-mueller
commented
Jan 29, 2024
sultaniman
reviewed
Jan 29, 2024
sultaniman
reviewed
Jan 29, 2024
sultaniman
reviewed
Jan 29, 2024
Contributor
sultaniman
left a comment
There was a problem hiding this comment.
Should we also add a README.md?
Collaborator
Author
absolutely, I'll type that up together with the integration test suite! |
4b3a01d to
e1b88d3
Compare
sultaniman
reviewed
Feb 6, 2024
… warning, refactorings
7b7f7e7 to
cb207d1
Compare
sultaniman
approved these changes
Feb 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tell us what you do here
verified source)Relevant issue
issue #310
More PR info
TODO before merge