-
-
Notifications
You must be signed in to change notification settings - Fork 8.9k
Expose objective functions to the Python interface. #12059
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
trivialfis
wants to merge
24
commits into
dmlc:master
Choose a base branch
from
trivialfis:py-obj-1
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 16 commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
47f62d9
[wip] Expose the Objective to Python.
trivialfis 51a067c
other objs.
trivialfis 8e45807
cleanup.
trivialfis 92082c4
doc string.
trivialfis b46d20d
cleanup.
trivialfis 049a7ec
vector leaf.
trivialfis c8a71a9
doc string.
trivialfis 821e1b1
doc string.
trivialfis 354391f
rename.
trivialfis 6a7152a
Remove synthetic classes.
trivialfis 4bde019
Cleanup.
trivialfis b517d7b
typo.
trivialfis 6029fc7
Revert changes to vector leaf.
trivialfis 4f66058
early exit.
trivialfis 4a30b9f
lint.
trivialfis 457b53e
IO tests.
trivialfis cd5bfba
not callable.
trivialfis 8816629
stringify.
trivialfis 1948ae7
Fix.
trivialfis 094c8ed
Disable the `cv` function.
trivialfis 0f10aff
Cleanup.
trivialfis 6639b94
Raise.
trivialfis 5bc828a
typo.
trivialfis e9d6673
more tests.
trivialfis File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just curious what the latency differences between using the python interface or internal. One possible simplification could be to always use the python, there is just one code path.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The internal assumes split gradient must be available, and only does an extra leaf value computation at the end of iteration if there's an extra leaf value gradient. This is easy to implement as we only need one extra step.
But that's not intuitive to users since the algorithm creates an extra "split gradient", at least that's the mental model. So, the interface assumes a value gradient is available, as in normal gradient boosting. The assumption is switched here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I misread the original question. There's no difference in latency, it's just setting parameter. Yes, I think a single code path would be super nice.